linux-kernel - Re: [PATCH 1/4] kbuild: remove redundant cleanups in scripts/link-vmlinux.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 May 2022 02:30:33 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Sedat Dilek <sedat.dilek@...il.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Michal Marek <michal.lkml@...kovi.net>
Subject: Re: [PATCH 1/4] kbuild: remove redundant cleanups in scripts/link-vmlinux.sh

On Sun, May 29, 2022 at 11:38 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
>
> On Sat, May 28, 2022 at 10:20 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
> >
> > These are cleaned by the top Makefile.
> >
> > vmlinux.o and .vmlinux.d matches the '*.[aios]' and '.*.d' patterns
> > respectively.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
>
> I applied this patchset on top of yesterday's kbuild.git#for-next
> (today's did not fit due to "kbuild: do not try to parse *.cmd files
> for objects provided by compiler").
>
> Might be related to this patchset or not:
>
> $ LC_ALL=C ll .*vmlinux*export*
> -rw-r--r-- 1 dileks dileks 4.2K May 29 15:11 ..vmlinux.export.o.cmd
> -rw-r--r-- 1 dileks dileks 508K May 29 15:11 .vmlinux.export.c
> -rw-r--r-- 1 dileks dileks 2.6M May 29 15:11 .vmlinux.export.o
>
> You see the leading double-dot for ..vmlinux.export.o.cmd - intended or not?

This is intended.

The source file (.vmlinux.export.c) is a dot file.

.*.cmd prepends one more dot.



>
> Tested-by: Sedat Dilek <sedat.dilek@...il.com> # LLVM-14 (x86-64)
>
> -Sedat-
>
> > ---
> >
> >  scripts/link-vmlinux.sh | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> > index a7f6196c7e41..844fc0125d72 100755
> > --- a/scripts/link-vmlinux.sh
> > +++ b/scripts/link-vmlinux.sh
> > @@ -309,8 +309,6 @@ cleanup()
> >         rm -f System.map
> >         rm -f vmlinux
> >         rm -f vmlinux.map
> > -       rm -f vmlinux.o
> > -       rm -f .vmlinux.d
> >         rm -f .vmlinux.objs
> >         rm -f .vmlinux.export.c
> >  }
> > --
> > 2.32.0
> >



-- 
Best Regards
Masahiro Yamada