linux-kernel - [BUG] scripts/checkpatch.pl: incorrect parsing of commit message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220530143021.43645-1-heinrich.schuchardt@canonical.com>
Date:   Mon, 30 May 2022 16:30:21 +0200
From:   Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
To:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
Cc:     Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        linux-kernel@...r.kernel.org,
        Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
Subject: [BUG] scripts/checkpatch.pl: incorrect parsing of commit message

The following text from a commit message

    "Building on RISC-V results in an error

        cc: error: ‘-march=native’: ISA string must begin with rv32 or rv64"

results in a false positive in scripts/checkpatch.pl:

    ERROR: Unrecognized email address:
    'error: ‘-march=native’: ISA string must begin with rv32 or rv64"'

If a line does not start in column 1 and does not contain an email
address, it is obviously not a Cc: tag and checkpatch.pl should not
indicate an error.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
---
 meson.build | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 507c146..bbf4650 100644
--- a/meson.build
+++ b/meson.build
@@ -17,7 +17,10 @@ pktgen_conf = configuration_data()
 # set up some global vars for compiler, platform, configuration, etc.
 cc = meson.get_compiler('c')
 
-add_project_arguments('-march=native', language: 'c')
+target = target_machine.cpu_family()
+if (target != 'riscv64')
+    add_project_arguments('-march=native', language: 'c')
+endif
 
 if get_option('enable-avx') and cc.has_argument('-mavx')
     add_project_arguments('-mavx', language: 'c')
-- 
2.36.1