linux-kernel - Re: [PATCH v2] net: ipv4: Avoid bounds check warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <928aa148-e666-783b-dbd4-9ea3172efafb@kernel.org>
Date:   Mon, 30 May 2022 10:10:11 -0600
From:   David Ahern <dsahern@...nel.org>
To:     zhanggenjian <zhanggenjian123@...il.com>, pabeni@...hat.com,
        edumazet@...gle.com, davem@...emloft.net, yoshfuji@...ux-ipv6.org,
        kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        huhai@...inos.cn
Subject: Re: [PATCH v2] net: ipv4: Avoid bounds check warning

On 5/26/22 4:12 AM, zhanggenjian wrote:
> From: huhai <huhai@...inos.cn>
> 
> Fix the following build warning when CONFIG_IPV6 is not set:
> 
> In function ‘fortify_memcpy_chk’,
>     inlined from ‘tcp_md5_do_add’ at net/ipv4/tcp_ipv4.c:1210:2:
> ./include/linux/fortify-string.h:328:4: error: call to ‘__write_overflow_field’ declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
>   328 |    __write_overflow_field(p_size_field, size);
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Suggested-by: Paolo Abeni <pabeni@...hat.com>
> Signed-off-by: huhai <huhai@...inos.cn>
> ---
>  net/ipv4/tcp_ipv4.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>