linux-kernel - Re: [PATCH crypto] crypto: memneq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YpUAmiBSb6oEr1oc@sol.localdomain>
Date:   Mon, 30 May 2022 10:36:26 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     herbert@...dor.apana.org.au, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zheng Bin <zhengbin13@...wei.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH crypto] crypto: memneq - move into lib/

On Sat, May 28, 2022 at 12:24:29PM +0200, Jason A. Donenfeld wrote:
> This is used by code that doesn't need CONFIG_CRYPTO, so move this into
> lib/ with a Kconfig option so that it can be selected by whatever needs
> it.
> 
> This fixes a linker error Zheng pointed out when
> CRYPTO_MANAGER_DISABLE_TESTS!=y and CRYPTO=m:
> 
>   lib/crypto/curve25519-selftest.o: In function `curve25519_selftest':
>   curve25519-selftest.c:(.init.text+0x60): undefined reference to `__crypto_memneq'
>   curve25519-selftest.c:(.init.text+0xec): undefined reference to `__crypto_memneq'
>   curve25519-selftest.c:(.init.text+0x114): undefined reference to `__crypto_memneq'
>   curve25519-selftest.c:(.init.text+0x154): undefined reference to `__crypto_memneq'
> 
> Reported-by: Zheng Bin <zhengbin13@...wei.com>
> Cc: Eric Biggers <ebiggers@...nel.org>
> Cc: stable@...r.kernel.org
> Fixes: aa127963f1ca ("crypto: lib/curve25519 - re-add selftests")
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> ---
> I'm traveling over the next week, and there are a few ways to skin this
> cat, so if somebody here sees issue, feel free to pick this v1 up and
> fashion a v2 out of it.
> 
>  crypto/Kconfig           | 1 +
>  crypto/Makefile          | 2 +-
>  lib/Kconfig              | 3 +++
>  lib/Makefile             | 1 +
>  lib/crypto/Kconfig       | 1 +
>  {crypto => lib}/memneq.c | 0
>  6 files changed, 7 insertions(+), 1 deletion(-)
>  rename {crypto => lib}/memneq.c (100%)

Reviewed-by: Eric Biggers <ebiggers@...gle.com>

- Eric