linux-kernel - Re: [PATCH 1/2] dt-bindings: pwm: add MT8365 SoC binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220530205120.q3gi2fhua5lbxnmj@helium.lan>
Date:   Mon, 30 May 2022 22:51:20 +0200
From:   Fabien Parent <fparent@...libre.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: pwm: add MT8365 SoC binding

On Mon, May 30, 2022 at 10:31:01PM +0200, Uwe Kleine-König wrote:
> On Mon, May 30, 2022 at 10:21:34PM +0200, Fabien Parent wrote:
> > Add binding documentation for the MT8365 SoC.
> > 
> > Signed-off-by: Fabien Parent <fparent@...libre.com>
> > ---
> >  Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> > index 25ed214473d7..ac5c58bbb22d 100644
> > --- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> > +++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
> > @@ -8,6 +8,7 @@ Required properties:
> >     - "mediatek,mt7628-pwm": found on mt7628 SoC.
> >     - "mediatek,mt7629-pwm": found on mt7629 SoC.
> >     - "mediatek,mt8183-pwm": found on mt8183 SoC.
> > +   - "mediatek,mt8365-pwm": found on mt8365 SoC.
> >     - "mediatek,mt8516-pwm": found on mt8516 SoC.
> >   - reg: physical base address and length of the controller's registers.
> >   - #pwm-cells: must be 2. See pwm.yaml in this directory for a description of
> > @@ -17,6 +18,7 @@ Required properties:
> >                  has no clocks
> >     - "top": the top clock generator
> >     - "main": clock used by the PWM core
> > +   - "pwm1-3": the five per PWM clocks for mt8365
> 
> I think you either want s/3/5/ or s/five/three/ here?!

Thanks. Fixed in v2.

BR,
Fabien

> 
> Best regards
> Uwe
> 
> -- 
> Pengutronix e.K.                           | Uwe Kleine-König            |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)