linux-kernel - Re: [PATCH crypto v2] crypto: blake2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9r5Fr4Zm585tLjv562kzB58iHjNjnRH8+YJ-3cY6b4WZg@mail.gmail.com>
Date:   Mon, 30 May 2022 09:54:28 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     David Laight <David.Laight@...lab.com>
Cc:     Eric Biggers <ebiggers@...nel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        gaochao <gaochao49@...wei.com>, Ard Biesheuvel <ardb@...nel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH crypto v2] crypto: blake2s - remove shash module

On 5/30/22, David Laight <David.Laight@...lab.com> wrote:
> From: Eric Biggers
>> Sent: 28 May 2022 18:20
>>
>> On Sat, May 28, 2022 at 11:57:01AM +0200, Jason A. Donenfeld wrote:
>> > > Also, the wrong value is being passed for the 'inc' argument.
>> >
>> > Are you sure? Not sure I'm seeing what you are on first glance.
>>
>> Yes, 'inc' is the increment amount per block.  It needs to always be
>> BLAKE2S_BLOCK_SIZE unless a partial block is being processed.
>
> IIRC it isn't used for partial blocks.
> Which rather begs the question as to why it is a parameter at all.

Again, with blake2s, please send a patch if you think there's an
improvement to be made.

In this case, I don't think you're right. See blake2s_final.

Jason