linux-kernel - Re: [PATCH] platform/x86: barco-p50-gpio: Add check for platform_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bkve4t0w.fsf@dell.be.48ers.dk>
Date:   Mon, 30 May 2022 23:20:15 +0200
From:   Peter Korsgaard <peter@...sgaard.com>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>
Cc:     santoshkumar.yadav@...co.com, peter.korsgaard@...co.com,
        hdegoede@...hat.com, markgross@...nel.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: barco-p50-gpio: Add check for
 platform_driver_register

>>>>> "Jiasheng" == Jiasheng Jiang <jiasheng@...as.ac.cn> writes:

 > As platform_driver_register() could fail, it should be better
 > to deal with the return value in order to maintain the code
 > consisitency.

 > Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for
 > identify LED/button on Barco P50 board")

 > Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>

Acked-by: Peter Korsgaard <peter.korsgaard@...co.com>


> ---
 >  drivers/platform/x86/barco-p50-gpio.c | 5 ++++-
 >  1 file changed, 4 insertions(+), 1 deletion(-)

 > diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
 > index 05534287bc26..8dd672339485 100644
 > --- a/drivers/platform/x86/barco-p50-gpio.c
 > +++ b/drivers/platform/x86/barco-p50-gpio.c
 > @@ -405,11 +405,14 @@ MODULE_DEVICE_TABLE(dmi, dmi_ids);
 >  static int __init p50_module_init(void)
 >  {
 >  	struct resource res = DEFINE_RES_IO(P50_GPIO_IO_PORT_BASE, P50_PORT_CMD + 1);
 > +	int ret;
 
 >  	if (!dmi_first_match(dmi_ids))
 >  		return -ENODEV;
 
 > -	platform_driver_register(&p50_gpio_driver);
 > +	ret = platform_driver_register(&p50_gpio_driver);
 > +	if (ret)
 > +		return ret;
 
 >  	gpio_pdev = platform_device_register_simple(DRIVER_NAME, PLATFORM_DEVID_NONE, &res, 1);
 >  	if (IS_ERR(gpio_pdev)) {
 > -- 

 > 2.25.1


-- 
Bye, Peter Korsgaard