linux-kernel - Re: [PATCH v2 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add clock property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c491f04b-2e60-4b52-d123-4659d4fa8d07@linaro.org>
Date:   Mon, 30 May 2022 09:57:37 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rahul T R <r-ravikumar@...com>
Cc:     robh+dt@...nel.org, nm@...com, vigneshr@...com, kishon@...com,
        krzysztof.kozlowski+dt@...aro.org, lee.jones@...aro.org,
        rogerq@...nel.org, devicetree@...r.kernel.org, kristo@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        s-anna@...com
Subject: Re: [PATCH v2 1/3] dt-bindings: mfd: ti,j721e-system-controller: Add
 clock property

On 30/05/2022 09:51, Rahul T R wrote:
> On 09:37-20220530, Krzysztof Kozlowski wrote:
>> On 30/05/2022 09:34, Rahul T R wrote:
>>> Add a pattern property for clock, also update the example with
>>> a clock node
>>>
>>> Signed-off-by: Rahul T R <r-ravikumar@...com>
>>> ---
>>>  .../bindings/mfd/ti,j721e-system-controller.yaml       | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>>> index fa86691ebf16..290b22cab52f 100644
>>> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
>>> @@ -48,6 +48,10 @@ patternProperties:
>>>      description:
>>>        This is the SERDES lane control mux.
>>>  
>>> +  "^clock@[0-9a-f]+$":
>>> +    type: object
>>> +    $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
>>> +
>>
>> Thanks for the changes, but the question what is this remains. Clock
>> consumers use "clocks" property. Is this a clock controller (provider)
>> instead?
>>
>> Best regards,
>> Krzysztof
> 
> Hi Krzysztof,
> 
> Yes, this is a clock provider node, I will add the
> correct description and will also update the
> example with a clock consumer node that is using
> a clock from this

Thanks for the description. Skip the consumer example please, just
mention shortly what is this. If this is one clock, then node name is
correct. If there are more clocks inside, then the node name should be
"clock-controller".

Best regards,
Krzysztof