linux-kernel - Re: [RFC 2/2] iio: accel: bma400: Add support for single and double tap events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 May 2022 10:56:48 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Jagath Jog J <jagathjog1996@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC 2/2] iio: accel: bma400: Add support for single and double
 tap events

On Sun, May 29, 2022 at 6:02 AM Jagath Jog J <jagathjog1996@...il.com> wrote:
>
> Add support for single and double tap events based on the tap threshold
> value and minimum quite time value between the taps. INT1 pin is used to

quiet (see below as well)

The INT1

> interrupt and event is pushed to userspace.

an event

...

> +#define BMA400_TAP_QUITE_MSK        GENMASK(3, 2)

QUIET ?

...

> +       /*
> +        * No need to change ODR when tap event is enabled because
> +        * tap interrupt is operating with the data rate of 200Hz.
> +        * See datasheet page 124.

When referring to the datasheet, please be more specific, i.e. table /
chart / section number and name, No page needed as it may  be changed
from version to version, also date of the document or revision would
be nice to add.

> +        */

-- 
With Best Regards,
Andy Shevchenko