linux-kernel - Re: [PATCH] virtio_balloon: check virtqueue_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a413652a9a9469f948fbfa2eae5c401@inspur.com>
Date:   Mon, 30 May 2022 02:16:20 +0000
From:   Bo Liu (刘波)-浪潮信息 
        <liubo03@...pur.com>
To:     "mst@...hat.com" <mst@...hat.com>
CC:     "david@...hat.com" <david@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio_balloon: check virtqueue_add_outbuf() return value

Adding this patch can avoid unnecessary VM exits and reduce the number of VM exits

-----邮件原件-----
发件人: Michael S. Tsirkin <mst@...hat.com> 
发送时间: 2022年5月27日 18:58
收件人: Bo Liu (刘波)-浪潮信息 <liubo03@...pur.com>
抄送: david@...hat.com; jasowang@...hat.com; virtualization@...ts.linux-foundation.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH] virtio_balloon: check virtqueue_add_outbuf() return value

On Fri, May 27, 2022 at 10:43:30AM +0000, Bo Liu (刘波)-浪潮信息 wrote:
> The purpose of this patch is, virtqueue_add_outbuf() adding data to 
> virtqueue may succeed or fail. If successful, it will call 
> virtqueue_kick() to notifie the host backend driver, but if the 
> virtqueue_add_outbuf() fails, the data is not successfully added to 
> the virtqueue, and the host back-end driver does not need to be notified for processing.
> 
> Thanks.

Why is it a problem if we do?

--
MST


Download attachment "smime.p7s" of type "application/pkcs7-signature" (3777 bytes)