linux-kernel - RE: [PATCH 4/4] Input: adp5588-keys - do not explicitly set device as wakeup source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR03MB6253063976AAAB80769049918EDD9@SJ0PR03MB6253.namprd03.prod.outlook.com>
Date:   Mon, 30 May 2022 10:11:40 +0000
From:   "Hennerich, Michael" <Michael.Hennerich@...log.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 4/4] Input: adp5588-keys - do not explicitly set device as
 wakeup source



> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Sent: Samstag, 28. Mai 2022 06:57
> To: Hennerich, Michael <Michael.Hennerich@...log.com>
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>; linux-
> input@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH 4/4] Input: adp5588-keys - do not explicitly set device as
> wakeup source
> 
> [External]
> 
> I2C core will set up device as a wakeup source and will configure interrupt as a
> wakeup interrupt if client is created with I2C_CLIENT_WAKE flag. Let's rely on
> this facility and to not unconditionally set up the device as wakeup device in the
> driver.
> 


Looks good! Thanks for the cleanup!

> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Acked-by: Michael Hennerich <michael.hennerich@...log.com>


> ---
>  drivers/input/keyboard/adp5588-keys.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/input/keyboard/adp5588-keys.c
> b/drivers/input/keyboard/adp5588-keys.c
> index df84a2998ed2..2a274240facb 100644
> --- a/drivers/input/keyboard/adp5588-keys.c
> +++ b/drivers/input/keyboard/adp5588-keys.c
> @@ -589,8 +589,6 @@ static int adp5588_probe(struct i2c_client *client,
>  	if (error)
>  		return error;
> 
> -	device_init_wakeup(&client->dev, 1);
> -
>  	dev_info(&client->dev, "Rev.%d keypad, irq %d\n", revid, client->irq);
>  	return 0;
>  }
> @@ -609,9 +607,6 @@ static int __maybe_unused adp5588_suspend(struct
> device *dev)
> 
>  	disable_irq(client->irq);
> 
> -	if (device_may_wakeup(&client->dev))
> -		enable_irq_wake(client->irq);
> -
>  	return 0;
>  }
> 
> @@ -619,9 +614,6 @@ static int __maybe_unused adp5588_resume(struct
> device *dev)  {
>  	struct i2c_client *client = to_i2c_client(dev);
> 
> -	if (device_may_wakeup(&client->dev))
> -		disable_irq_wake(client->irq);
> -
>  	enable_irq(client->irq);
> 
>  	return 0;
> --
> 2.36.1.124.g0e6072fb45-goog