linux-kernel - Re: [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and firmware loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220530105329.GV38351@ediswmail.ad.cirrus.com>
Date:   Mon, 30 May 2022 10:53:29 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Takashi Iwai <tiwai@...e.de>
CC:     Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org>,
        <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 00/17] ALSA: hda: cirrus: Add initial DSP support and
 firmware loading

On Mon, May 30, 2022 at 12:45:08PM +0200, Takashi Iwai wrote:
> On Mon, 30 May 2022 12:34:15 +0200,
> Charles Keepax wrote:
> Well, if an ALSA control can trigger the firmware loading, that's
> already fragile.  A firmware loading is a heavy task, which should
> happen only at probing and/or resuming in general.  Do we have other
> drivers doing the f/w loading triggered by a kctl...?
> 
> > I guess we could look at adding locked versions of the add
> > control functions as well if that might be preferred?
> 
> If the patterns of additional kctls (specific for firmware?) are
> fixed, we may create all such kctls beforehand and let them inactive
> unless the corresponding firmware is really loaded, too.
> 

I am afraid we do, basically all the Wolfson/Cirrus audio devices
allow you to select the firmware through a kctl. The patterns of
controls are specific to the firmwares, so we can't really create
them ahead of time. One could maybe look at changing when the
firmwares are loaded, such as attempting to load all possible
firmwares on boot or something but its a fairly sizable change
that isn't without some side effects.

Thanks,
Charles