linux-kernel - Re: [PATCH v4 16/17] ALSA: hda: cs35l41: Support Firmware switching and reloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd0817a9-16f9-a08f-fcde-97788de445d3@perex.cz>
Date:   Mon, 30 May 2022 13:31:58 +0200
From:   Jaroslav Kysela <perex@...ex.cz>
To:     Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
        Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org,
        Stefan Binding <sbinding@...nsource.cirrus.com>
Subject: Re: [PATCH v4 16/17] ALSA: hda: cs35l41: Support Firmware switching
 and reloading

On 25. 05. 22 15:16, Vitaly Rodionov wrote:

> This patch adds 2 ALSA Controls for each amp:
> "DSP1 Firmware Load"
> "DSP1 Firmware Type"

...

> +	struct snd_kcontrol_new fw_type_ctl = {
> +		.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> +		.info = cs35l41_fw_type_ctl_info,
> +		.get = cs35l41_fw_type_ctl_get,
> +		.put = cs35l41_fw_type_ctl_put,
> +	};
> +	struct snd_kcontrol_new fw_load_ctl = {
> +		.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> +		.info = snd_ctl_boolean_mono_info,
> +		.get = cs35l41_fw_load_ctl_get,
> +		.put = cs35l41_fw_load_ctl_put,
> +	};

I don't think that those controls should be SNDRV_CTL_ELEM_IFACE_MIXER type. 
The SNDRV_CTL_ELEM_IFACE_CARD seems more appropriate (service controls for the 
sound card).

						Jaroslav

-- 
Jaroslav Kysela <perex@...ex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.