linux-kernel - Re: [PATCH bpf-next 1/3] selftests/bpf: Shuffle cookies symbols in kprobe multi test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F27191C0-A530-4D18-9FA1-8D47DD1ACF8A@fb.com>
Date:   Mon, 30 May 2022 05:37:08 +0000
From:   Song Liu <songliubraving@...com>
To:     Jiri Olsa <jolsa@...nel.org>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, Martin Lau <kafai@...com>,
        Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH bpf-next 1/3] selftests/bpf: Shuffle cookies symbols in
 kprobe multi test



> On May 27, 2022, at 1:56 PM, Jiri Olsa <jolsa@...nel.org> wrote:
> 
> There's a kernel bug that causes cookies to be misplaced and
> the reason we did not catch this with this test is that we
> provide bpf_fentry_test* functions already sorted by name.
> 
> Shuffling function bpf_fentry_test2 deeper in the list and
> keeping the current cookie values as before will trigger
> the bug.
> 
> The kernel fix is coming in following changes.
> 
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>

Acked-by: Song Liu <songliubraving@...com>