linux-kernel - Re: [PATCH v16 4/4] m68k: introduce a virtual m68k machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3mF9CuWC2Tw3VvDVGFgpjAwtMHSjoNa49bny7gMEw8sQ@mail.gmail.com>
Date:   Tue, 31 May 2022 08:20:15 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Laurent Vivier <laurent@...ier.eu>
Cc:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-m68k@...ts.linux-m68k.org,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-rtc@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        John Stultz <john.stultz@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [PATCH v16 4/4] m68k: introduce a virtual m68k machine

On Tue, May 31, 2022 at 8:05 AM Laurent Vivier <laurent@...ier.eu> wrote:
> > This select VIRTIO_MMIO can cause a kconfig warning:
> >
> > WARNING: unmet direct dependencies detected for VIRTIO_MMIO
> >    Depends on [n]: VIRTIO_MENU [=n] && HAS_IOMEM [=y] && HAS_DMA [=y]
>
> In my repo, VIRTIO_MMIO has no dependency on VIRTIO_MENU:
>
> ./drivers/virtio/Kconfig
> config VIRTIO_MMIO
>          tristate "Platform bus driver for memory mapped virtio devices"
>          depends on HAS_IOMEM && HAS_DMA
>
> >    Selected by [y]:
> >    - VIRT [=y] && M68KCLASSIC [=y] && MMU [=y]
>

The dependency is expressed differently here, but this is the
same as writing 'depends on VIRTIO_MENU':

menuconfig VIRTIO_MENU
        bool "Virtio drivers"
        default y

if VIRTIO_MENU

config VIRTIO_MMIO
        tristate "Platform bus driver for memory mapped virtio devices"

endif


        Arnd