linux-kernel - Re: [PATCH v16 4/4] m68k: introduce a virtual m68k machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b783435-e734-5391-e758-d709e0462839@infradead.org>
Date:   Mon, 30 May 2022 18:14:28 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Laurent Vivier <laurent@...ier.eu>, linux-kernel@...r.kernel.org
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-m68k@...ts.linux-m68k.org,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-rtc@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        John Stultz <john.stultz@...aro.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [PATCH v16 4/4] m68k: introduce a virtual m68k machine

Hi--

On 4/6/22 13:15, Laurent Vivier wrote:
> diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
> index eeab4f3e6c19..188a8f8a0104 100644
> --- a/arch/m68k/Kconfig.machine
> +++ b/arch/m68k/Kconfig.machine
> @@ -149,6 +149,23 @@ config SUN3
>  
>  	  If you don't want to compile a kernel exclusively for a Sun 3, say N.
>  
> +config VIRT
> +	bool "Virtual M68k Machine support"
> +	depends on MMU
> +	select GENERIC_CLOCKEVENTS
> +	select GOLDFISH
> +	select GOLDFISH_TIMER
> +	select GOLDFISH_TTY
> +	select M68040
> +	select MMU_MOTOROLA if MMU
> +	select RTC_CLASS
> +	select RTC_DRV_GOLDFISH
> +	select TTY
> +	select VIRTIO_MMIO

This select VIRTIO_MMIO can cause a kconfig warning:

WARNING: unmet direct dependencies detected for VIRTIO_MMIO
  Depends on [n]: VIRTIO_MENU [=n] && HAS_IOMEM [=y] && HAS_DMA [=y]
  Selected by [y]:
  - VIRT [=y] && M68KCLASSIC [=y] && MMU [=y]


> +	help
> +	  This options enable a pure virtual machine based on m68k,
> +	  VIRTIO MMIO devices and GOLDFISH interfaces (TTY, RTC, PIC)

The sentence above needs an ending period ('.').

> +
>  config PILOT
>  	bool

-- 
~Randy