linux-kernel - Re: [PATCH] linux/time32.h: correct ns_to_kernel_old

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3nknJgEDESGdJH91jMj6R_xydFqWASd8r5BbesdvMBgA@mail.gmail.com>
Date:   Tue, 31 May 2022 13:25:56 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Chanho Park <chanho61.park@...sung.com>
Cc:     Arnd Bergmann <arnd@...db.de>, John Stultz <jstultz@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] linux/time32.h: correct ns_to_kernel_old_timeval prototype

On Tue, May 31, 2022 at 8:43 AM Chanho Park <chanho61.park@...sung.com> wrote:
>
> The function argument is defined with const identifier in
> kernel/time/time.c but the prototype looks different between time.c and
> time32.h. There is a review[1] why it was omitted during review stage but
> they should be matched.

Thanks for report and the patch!

Since the 'const' keyword is still useless here, I would suggest
instead dropping
it from the function definition where I accidentally left it, and from the
related ns_to_timespec64() as well, both its declaration and definition.

       Arnd