linux-kernel - Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 May 2022 17:29:48 +0530
From:   Puranjay Mohan <p-mohan@...com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <linux-kernel@...r.kernel.org>
CC:     <davem@...emloft.net>, <edumazet@...gle.com>,
        <krzysztof.kozlowski+dt@...aro.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <nm@...com>, <ssantosh@...nel.org>,
        <s-anna@...com>, <linux-arm-kernel@...ts.infradead.org>,
        <rogerq@...nel.org>, <grygorii.strashko@...com>, <vigneshr@...com>,
        <kishon@...com>, <robh+dt@...nel.org>, <afd@...com>,
        <andrew@...n.ch>
Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver
 bindings

Hi Krzysztof,

On 31/05/22 17:18, Krzysztof Kozlowski wrote:
> On 31/05/2022 13:27, Puranjay Mohan wrote:
>>>> +examples:
>>>> +  - |
>>>> +
>>>> +    /* Example k3-am654 base board SR2.0, dual-emac */
>>>> +    pruss2_eth: pruss2_eth {
>>>> +            compatible = "ti,am654-icssg-prueth";
>>>
>>> Again missed Rob's comment.
>>
>> One of Rob's comment was to make the indentation as 4 which I have done.
> 
> I clearly do not see indentation of 4, but there is 8 instead.

I changed the indentation at the wrong place.

> 
> Let's count:
> +    pruss2_eth: pruss2_eth {
^ here, it was 8 in v1 so, I changed it to 4

> +            compatible = "ti,am654-icssg-prueth";
>      12345678^
> 

Compatible is the child of pruss2_eth, so, It should have 4+4 = 8?

> It's 8...
> 
>>
>> The second comment was about 'ti,prus'.
>>
>> So, ti,prus , firmware-name, and ti,pruss-gp-mux-sel are a part of
>> remoteproc/ti,pru-consumer.yaml which I have included with
>>
>> allOf:
>>   - $ref: /schemas/remoteproc/ti,pru-consumer.yaml#
>>
>> So, I thought it is not required to add them again.
>>
>> I will add it in next version, if that is how it should be done.
> I was referring to the indentation.
> 
> Krzysztof

Thanks,
Puranjay