linux-kernel - Re: [PATCH] mm/memremap: fix missing call to untrack_pfn() in pagemap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e2005c7-8ccb-7d07-57ed-a04cfd7af369@redhat.com>
Date:   Tue, 31 May 2022 14:48:20 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Miaohe Lin <linmiaohe@...wei.com>, akpm@...ux-foundation.org
Cc:     anshuman.khandual@....com, osalvador@...e.de, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/memremap: fix missing call to untrack_pfn() in
 pagemap_range()

On 31.05.22 14:26, Miaohe Lin wrote:
> We forget to call untrack_pfn() to pair with track_pfn_remap() when range
> is not allowed to hotplug. Fix it by jump err_kasan.
> 
> Fixes: bca3feaa0764 ("mm/memory_hotplug: prevalidate the address range being added with platform")
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  mm/memremap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memremap.c b/mm/memremap.c
> index 2b92e97cb25b..b870a659eee6 100644
> --- a/mm/memremap.c
> +++ b/mm/memremap.c
> @@ -214,7 +214,7 @@ static int pagemap_range(struct dev_pagemap *pgmap, struct mhp_params *params,
>  
>  	if (!mhp_range_allowed(range->start, range_len(range), !is_private)) {
>  		error = -EINVAL;
> -		goto err_pfn_remap;
> +		goto err_kasan;
>  	}
>  
>  	mem_hotplug_begin();

Thanks!

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb