[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220531181246.190729-1-jose.exposito89@gmail.com>
Date: Tue, 31 May 2022 20:12:42 +0200
From: José Expósito <jose.exposito89@...il.com>
To: jikos@...nel.org
Cc: benjamin.tissoires@...hat.com, spbnick@...il.com,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
stefanberzl@...il.com, dlatypov@...gle.com,
kunit-dev@...glegroups.com,
José Expósito <jose.exposito89@...il.com>
Subject: [PATCH v3 0/4] Add support for XP-PEN Deco L
Hello everyone,
This patchset adds support for the UGEE XP-PEN Deco L tablet.
This device belongs to a family of tablets that must receive a chunk of
magic data in order to be enabled (named UGEE v2 internally).
Once the device is enabled, its parameters can be discovered by parsing
a report descriptor. HUION v1 tablets have a similar report descriptor
but, in the case of UGEE v2 tablets, the number of buttons are also
discoverable [1].
The ability to discover the number of buttons is the reason for the
first 3 patches. They enable frame templates.
Because I lack the hardware to fully test this driver, I added some
KUnit tests to make sure no bugs are introduced.
I didn't see any other test in the subsystem (and I doubt I'm the first
person writing one) so please let me know if I need to move the test to
a different place.
The last patch enables the tablet.
Best wishes,
José Expósito
[1] I don't own a HUION v1 device, so I'm not sure if the information
about the number of buttons is also present and it is not used in
the driver for some reason.
[2] https://lore.kernel.org/linux-input/20220516112159.GA74406@elementary/T/#t
---
v1 - Initial version
https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/
v2 - Fix some errors reported by the kernel test robot:
- Add MODULE_DESCRIPTION/LICENSE/AUTHOR to hid-uclogic-rdesc-test.c
- Remove unused variable in uclogic_params_ugee_v2_init
- Add sparse __force anotation in the result of cpu_to_le16
- Add DISABLE_STRUCTLEAK_PLUGIN for KUnit tests
https://lore.kernel.org/linux-input/20220518224702.1409327-1-jose.exposito89@gmail.com/T/
v3 - This version:
- Improve Kconfig message
- Add .kunitconfig. Thanks to Daniel Latypov for suggesting it in an
unrelated patch:
https://lore.kernel.org/dri-devel/CAGS_qxpV2SsihEdgXZ6+7N0dxLmdRANq+qE4iUZ2aNrf6vuLYg@mail.gmail.com/
José Expósito (4):
HID: uclogic: Make template placeholder IDs generic
HID: uclogic: Add KUnit tests for uclogic_rdesc_template_apply()
HID: uclogic: Allow to generate frame templates
HID: uclogic: Add support for XP-PEN Deco L
drivers/hid/.kunitconfig | 2 +
drivers/hid/Kconfig | 11 ++
drivers/hid/Makefile | 3 +
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-uclogic-core.c | 2 +
drivers/hid/hid-uclogic-params.c | 201 +++++++++++++++++++++++-
drivers/hid/hid-uclogic-rdesc-test.c | 219 +++++++++++++++++++++++++++
drivers/hid/hid-uclogic-rdesc.c | 124 ++++++++++++++-
drivers/hid/hid-uclogic-rdesc.h | 24 ++-
9 files changed, 573 insertions(+), 14 deletions(-)
create mode 100644 drivers/hid/.kunitconfig
create mode 100644 drivers/hid/hid-uclogic-rdesc-test.c
--
2.25.1
Powered by blists - more mailing lists