linux-kernel - Re: [PATCH -next] Input: joystick: Raspberry Pi Sense HAT depends on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YpaEUZYtlVf2aCuA@google.com>
Date:   Tue, 31 May 2022 14:10:41 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Charles Mirabile <cmirabil@...hat.com>,
        Daniel Bauman <dbauman@...hat.com>,
        Mwesigwa Guma <mguma@...hat.com>,
        Joel Savitz <jsavitz@...hat.com>, linux-input@...r.kernel.org
Subject: Re: [PATCH -next] Input: joystick: Raspberry Pi Sense HAT depends on
 HAS_IOMEM

On Mon, May 30, 2022 at 07:29:42PM -0700, Randy Dunlap wrote:
> Since JOYSTICK_SENSEHAT selects MFD_SIMPLE_MFD_I2C and the latter
> depends on HAS_IOMEM, and since 'select' does not follow any
> dependency chains, JOYSTICK_SENSEHAT should also depend on HAS_IOMEM
> to prevent a kconfig warning and a build error:
> 
> WARNING: unmet direct dependencies detected for MFD_SIMPLE_MFD_I2C
>   Depends on [n]: HAS_IOMEM [=n] && I2C [=y]
>   Selected by [y]:
>   - JOYSTICK_SENSEHAT [=y] && INPUT_JOYSTICK [=y] && INPUT [=y] && I2C [=y]
> 
> s390-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe':
> simple-mfd-i2c.c:(.text+0xc8): undefined reference to `devm_mfd_add_devices'
> 
> Fixes: 41657514c796 ("Input: add Raspberry Pi Sense HAT joystick driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Charles Mirabile <cmirabil@...hat.com>
> Cc: Daniel Bauman <dbauman@...hat.com>
> Cc: Mwesigwa Guma <mguma@...hat.com>
> Cc: Joel Savitz <jsavitz@...hat.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: linux-input@...r.kernel.org

Applied, thank you.

-- 
Dmitry