linux-kernel - Re: [PATCH] perf evlist: Extend arch_evsel__must_be_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fWTKLFuuDL6uCn1y3DrmDnq8zvReTpjZL+dW+eRQ8=MtQ@mail.gmail.com>
Date:   Wed, 1 Jun 2022 09:00:10 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     zhengjun.xing@...ux.intel.com
Cc:     acme@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...el.com, jolsa@...hat.com,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        adrian.hunter@...el.com, ak@...ux.intel.com,
        kan.liang@...ux.intel.com
Subject: Re: [PATCH] perf evlist: Extend arch_evsel__must_be_in_group to
 support hybrid systems

On Wed, Jun 1, 2022 at 8:25 AM <zhengjun.xing@...ux.intel.com> wrote:
>
> From: Zhengjun Xing <zhengjun.xing@...ux.intel.com>
>
> For the hybrid system, the "slots" event changes to "cpu_core/slots/", need
> extend API arch_evsel__must_be_in_group() to support hybrid systems.
>
> In the origin code, for hybrid system event "cpu_core/slots/", the output
> of the API arch_evsel__must_be_in_group() is "false" (in fact,it should be
> "true"). Currently only one API evsel__remove_from_group() calls it. In
> evsel__remove_from_group(), it adds the second condition to check, so the
> output of evsel__remove_from_group() still is correct. That's the reason
> why there isn't an instant error. I'd like to fix the issue found in API
> arch_evsel__must_be_in_group() in case someone else using the function in
> the other place.
>
> Fixes: d98079c05b5a ("perf evlist: Keep topdown counters in weak group")
> Signed-off-by: Zhengjun Xing <zhengjun.xing@...ux.intel.com>
> Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>

Acked-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/arch/x86/util/evsel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/x86/util/evsel.c b/tools/perf/arch/x86/util/evsel.c
> index 88306183d629..ff4561b7b600 100644
> --- a/tools/perf/arch/x86/util/evsel.c
> +++ b/tools/perf/arch/x86/util/evsel.c
> @@ -57,6 +57,6 @@ bool arch_evsel__must_be_in_group(const struct evsel *evsel)
>                 return false;
>
>         return evsel->name &&
> -               (!strcasecmp(evsel->name, "slots") ||
> +               (strcasestr(evsel->name, "slots") ||
>                  strcasestr(evsel->name, "topdown"));
>  }
> --
> 2.25.1
>