linux-kernel - Re: [PATCH AUTOSEL 5.18 35/49] KVM: arm64: vgic: Do not ignore vgic_its_restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875ylk5o4p.wl-maz@kernel.org>
Date:   Wed, 01 Jun 2022 17:45:10 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Ricardo Koller <ricarkol@...gle.com>,
        Oliver Upton <oupton@...gle.com>, catalin.marinas@....com,
        will@...nel.org, eric.auger@...hat.com, yuzhe@...china.com,
        justin.he@....com, linux-arm-kernel@...ts.infradead.org,
        kvmarm@...ts.cs.columbia.edu
Subject: Re: [PATCH AUTOSEL 5.18 35/49] KVM: arm64: vgic: Do not ignore vgic_its_restore_cte failures

On Wed, 01 Jun 2022 14:51:59 +0100,
Sasha Levin <sashal@...nel.org> wrote:
> 
> From: Ricardo Koller <ricarkol@...gle.com>
> 
> [ Upstream commit a1ccfd6f6e06eceb632cc29c4f15a32860f05a7e ]
> 
> Restoring a corrupted collection entry (like an out of range ID) is
> being ignored and treated as success. More specifically, a
> vgic_its_restore_cte failure is treated as success by
> vgic_its_restore_collection_table.  vgic_its_restore_cte uses positive
> and negative numbers to return error, and +1 to return success.  The
> caller then uses "ret > 0" to check for success.
> 
> Fix this by having vgic_its_restore_cte only return negative numbers on
> error.  Do this by changing alloc_collection return codes to only return
> negative numbers on error.
> 
> Signed-off-by: Ricardo Koller <ricarkol@...gle.com>
> Reviewed-by: Oliver Upton <oupton@...gle.com>
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> Link: https://lore.kernel.org/r/20220510001633.552496-4-ricarkol@google.com
> Signed-off-by: Sasha Levin <sashal@...nel.org>

Same thing here. This wasn't tagged for stable. I don't think there is
much value in taking this in isolation.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.