linux-kernel - Re: [PATCH] x86/ftrace: Fix objtool vmlinux.o __fentry_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220601164741.r547yrz4p6jea6ih@treble>
Date:   Wed, 1 Jun 2022 09:47:41 -0700
From:   Josh Poimboeuf <jpoimboe@...nel.org>
To:     x86@...nel.org
Cc:     linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] x86/ftrace: Fix objtool vmlinux.o __fentry__ warning

On Wed, Jun 01, 2022 at 09:30:53AM -0700, Josh Poimboeuf wrote:
> The 'save_mcount_regs' macro does funny things with the frame pointer,
> which objtool doesn't approve of.  So OBJECT_FILES_NON_STANDARD is used
> with CONFIG_FRAME_POINTER to tell objtool to skip the entire file when
> frame pointers are enabled.
> 
> However, the file-wide OBJECT_FILES_NON_STANDARD annotation is now
> deprecated, because it doesn't work for IBT, where objtool runs on
> vmlinux.o.  Use more fine-grained function-specific annotations
> instead.
> 
> Fixes the following warning:
> 
>   vmlinux.o: warning: objtool: __fentry__+0x16: return with modified stack frame
> 
> Fixes: ed53a0d97192 ("x86/alternative: Use .ibt_endbr_seal to seal indirect calls")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...nel.org>

NACK - I just found another robot warning for this one.

-- 
Josh