linux-kernel - Re: [PATCH] binder: fix sender

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHRSSEwMvw2A6N-su40Odbs7AH4EjQ1nVWrrG49aFKUC1PpFug@mail.gmail.com>
Date:   Wed, 1 Jun 2022 10:35:16 -0700
From:   Todd Kjos <tkjos@...gle.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Carlos Llamas <cmllamas@...gle.com>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Todd Kjos <tkjos@...roid.com>,
        "Cc: Android Kernel" <kernel-team@...roid.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Christopher Ferris <cferris@...gle.com>
Subject: Re: [PATCH] binder: fix sender_euid type in uapi header

On Wed, Jun 1, 2022 at 9:53 AM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> On Wed, Jun 1, 2022 at 10:00 AM Carlos Llamas <cmllamas@...gle.com> wrote:
> >
> > The {pid,uid}_t fields of struct binder_transaction were recently
> > replaced to use kernel types in commit 169adc2b6b3c ("android/binder.h:
> > add linux/android/binder(fs).h to UAPI compile-test coverage").
> >
> > However, using __kernel_uid_t here breaks backwards compatibility in
> > architectures using 16-bits for this type, since glibc and some others
> > still expect a 32-bit uid_t. Instead, let's use __kernel_uid32_t which
> > avoids this compatibility problem.
> >
> > Fixes: 169adc2b6b3c ("android/binder.h: add linux/android/binder(fs).h to UAPI compile-test coverage")
> > Reported-by: Christopher Ferris <cferris@...gle.com>
> > Signed-off-by: Carlos Llamas <cmllamas@...gle.com>
> > ---
>
> Ahhh, good catch.
>
> Thank you for fixing this!
>
>  Reviewed-by: Masahiro Yamada <masahiroy@...nel.org>

Acked-by: Todd Kjos <tkjos@...gle.com>

>
>
> >  include/uapi/linux/android/binder.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/linux/android/binder.h b/include/uapi/linux/android/binder.h
> > index 11157fae8a8e..688bcdaeed53 100644
> > --- a/include/uapi/linux/android/binder.h
> > +++ b/include/uapi/linux/android/binder.h
> > @@ -289,7 +289,7 @@ struct binder_transaction_data {
> >         /* General information about the transaction. */
> >         __u32           flags;
> >         __kernel_pid_t  sender_pid;
> > -       __kernel_uid_t  sender_euid;
> > +       __kernel_uid32_t        sender_euid;
> >         binder_size_t   data_size;      /* number of bytes of data */
> >         binder_size_t   offsets_size;   /* number of bytes of offsets */
> >
> > --
> > 2.36.1.255.ge46751e96f-goog
> >
>
>
> --
> Best Regards
> Masahiro Yamada