linux-kernel - Re: [PATCH] MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to TLS support removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Jun 2022 21:08:06 +0300
From:   Leon Romanovsky <leonro@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Boris Pismenny <borisp@...dia.com>, <netdev@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Saeed Mahameed" <saeedm@...dia.com>
Subject: Re: [PATCH] MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to
 TLS support removal

On Wed, Jun 01, 2022 at 10:30:39AM -0700, Jakub Kicinski wrote:
> On Wed, 1 Jun 2022 13:18:12 +0300 Leon Romanovsky wrote:
> > On Wed, Jun 01, 2022 at 06:57:38AM +0200, Lukas Bulwahn wrote:
> > > Commit 40379a0084c2 ("net/mlx5_fpga: Drop INNOVA TLS support") removes all
> > > files in the directory drivers/net/ethernet/mellanox/mlx5/core/accel/, but
> > > misses to adjust its reference in MAINTAINERS.
> > > 
> > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a
> > > broken reference.
> > > 
> > > Remove the file entry to the removed directory in MELLANOX ETHERNET INNOVA
> > > DRIVERS.
> > > 
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> > > ---
> > > Leon, please pick this minor non-urgent clean-up patch on top of the commit
> > > above.  
> > 
> > Thanks, we will submit it once net-next will be open.
> 
> It should go via net FWIW.

I'm slightly confused here.

According to net policy, the patches that goes there should have Fixes
line, but Fixes lines are added for bugs [1].

This forgotten line in MAINTAINERS doesn't cause to any harm to
users/developers.

So when should I put Fixes line in netdev?

[1] https://lore.kernel.org/netdev/20211208070842.0ace6747@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/

Thanks