linux-kernel - [intel-tdx:kvm-upstream-workaround 422/422] arch/x86/kvm/mmu/mmu.c:4546:13: error: implicit declaration of function 'get_user_page_fast'; did you mean 'get_user_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 1 Jun 2022 11:51:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xiaoyao Li <xiaoyao.li@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Isaku Yamahata <isaku.yamahata@...el.com>
Subject: [intel-tdx:kvm-upstream-workaround 422/422]
 arch/x86/kvm/mmu/mmu.c:4546:13: error: implicit declaration of function
 'get_user_page_fast'; did you mean 'get_user_pages_fast'?

tree:   https://github.com/intel/tdx.git kvm-upstream-workaround
head:   4e487b52e144ed36e4ae202e7103e63679710095
commit: 4e487b52e144ed36e4ae202e7103e63679710095 [422/422] KVM: x86/mmu: Use get_user_page_fast instead of get_user_page_fast_only
config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220601/202206011134.9CrAT8m1-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel/tdx/commit/4e487b52e144ed36e4ae202e7103e63679710095
        git remote add intel-tdx https://github.com/intel/tdx.git
        git fetch --no-tags intel-tdx kvm-upstream-workaround
        git checkout 4e487b52e144ed36e4ae202e7103e63679710095
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kvm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/kvm_host.h:47,
                    from arch/x86/kvm/irq.h:15,
                    from arch/x86/kvm/mmu/mmu.c:18:
   include/linux/memfile_notifier.h:87:57: error: unknown type name 'flags'
      87 | static int memfile_register_notifier(struct file *file, flags,
         |                                                         ^~~~~
   arch/x86/kvm/mmu/mmu.c: In function 'kvm_faultin_pfn_private_mapped':
>> arch/x86/kvm/mmu/mmu.c:4546:13: error: implicit declaration of function 'get_user_page_fast'; did you mean 'get_user_pages_fast'? [-Werror=implicit-function-declaration]
    4546 |         if (get_user_page_fast(hva, FOLL_WRITE, page))
         |             ^~~~~~~~~~~~~~~~~~
         |             get_user_pages_fast
   In file included from include/linux/kvm_host.h:47,
                    from arch/x86/kvm/irq.h:15,
                    from arch/x86/kvm/mmu/mmu.c:18:
   At top level:
   include/linux/memfile_notifier.h:93:13: warning: 'memfile_unregister_notifier' defined but not used [-Wunused-function]
      93 | static void memfile_unregister_notifier(struct memfile_notifier *notifier)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/memfile_notifier.h:82:13: warning: 'memfile_notifier_invalidate' defined but not used [-Wunused-function]
      82 | static void memfile_notifier_invalidate(struct memfile_node *node,
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/memfile_notifier.h:77:13: warning: 'memfile_notifier_populate' defined but not used [-Wunused-function]
      77 | static void memfile_notifier_populate(struct memfile_node *node,
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/memfile_notifier.h:72:12: warning: 'memfile_node_set_flags' defined but not used [-Wunused-function]
      72 | static int memfile_node_set_flags(struct file *file, unsigned long flags)
         |            ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/memfile_notifier.h:68:13: warning: 'memfile_register_backing_store' defined but not used [-Wunused-function]
      68 | static void memfile_register_backing_store(struct memfile_backing_store *bs)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +4546 arch/x86/kvm/mmu/mmu.c

  4527	
  4528	/*
  4529	 * Private page can't be release on mmu_notifier without losing page contents.
  4530	 * The help, callback, from backing store is needed to allow page migration.
  4531	 * For now, pin the page.
  4532	 */
  4533	static int kvm_faultin_pfn_private_mapped(struct kvm_vcpu *vcpu,
  4534					    struct kvm_page_fault *fault)
  4535	{
  4536		hva_t hva = gfn_to_hva_memslot(fault->slot, fault->gfn);
  4537		struct page *page[1];
  4538	
  4539		fault->map_writable = false;
  4540		fault->pfn = KVM_PFN_ERR_FAULT;
  4541		if (hva == KVM_HVA_ERR_RO_BAD || hva == KVM_HVA_ERR_BAD)
  4542			return RET_PF_INVALID;
  4543	
  4544		/* TDX allows only RWX.  Read-only isn't supported. */
  4545		WARN_ON_ONCE(!fault->write);
> 4546		if (get_user_page_fast(hva, FOLL_WRITE, page))
  4547			return RET_PF_INVALID;
  4548	
  4549		fault->map_writable = true;
  4550		fault->pfn = page_to_pfn(page[0]);
  4551		return RET_PF_CONTINUE;
  4552	}
  4553	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp