linux-kernel - Re: [PATCH v19 12/20] s390/vfio-ap: allow hot plug/unplug of AP devices when assigned/unassigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <164f0852-3d7c-7d38-6fb2-9cacf6728ede@linux.ibm.com>
Date:   Wed, 1 Jun 2022 14:54:45 -0400
From:   "Jason J. Herne" <jjherne@...ux.ibm.com>
To:     Tony Krowiak <akrowiak@...ux.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     freude@...ux.ibm.com, borntraeger@...ibm.com, cohuck@...hat.com,
        mjrosato@...ux.ibm.com, pasic@...ux.ibm.com,
        alex.williamson@...hat.com, kwankhede@...dia.com,
        fiuczy@...ux.ibm.com
Subject: Re: [PATCH v19 12/20] s390/vfio-ap: allow hot plug/unplug of AP
 devices when assigned/unassigned

On 4/4/22 18:10, Tony Krowiak wrote:
> Let's hot plug an adapter, domain or control domain into the guest when it
> is assigned to a matrix mdev that is attached to a KVM guest. Likewise,
> let's hot unplug an adapter, domain or control domain from the guest when
> it is unassigned from a matrix_mdev that is attached to a KVM guest.
> 
> Whenever an assignment or unassignment of an adapter, domain or control
> domain is performed, the APQNs and control domains assigned to the matrix
> mdev will be filtered and assigned to the AP control block
> (APCB) that supplies the AP configuration to the guest so that no
> adapter, domain or control domain that is not in the host's AP
> configuration nor any APQN that does not reference a queue device bound
> to the vfio_ap device driver is assigned.
> 
> After updating the APCB, if the mdev is in use by a KVM guest, it is
> hot plugged into the guest to dynamically provide access to the adapters,
> domains and control domains provided via the newly refreshed APCB.
> 
> Signed-off-by: Tony Krowiak <akrowiak@...ux.ibm.com>
> ---
>   drivers/s390/crypto/vfio_ap_ops.c | 112 +++++++++++++++---------------
>   1 file changed, 57 insertions(+), 55 deletions(-)

Seems sane.

Reviewed-by: Jason J. Herne <jjherne@...ux.ibm.com>