[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220601184711.GA201654-robh@kernel.org>
Date: Wed, 1 Jun 2022 13:47:11 -0500
From: Rob Herring <robh@...nel.org>
To: Max Fierke <max@...fierke.com>
Cc: thierry.reding@...il.com, sam@...nborg.org, airlied@...ux.ie,
daniel@...ll.ch, krzysztof.kozlowski+dt@...aro.org,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: display: Add bindings for ClockworkPi
CWD686
On Wed, Jun 01, 2022 at 12:17:47AM -0500, Max Fierke wrote:
> The CWD686 is a 6.86" IPS LCD panel used as the primary
> display in the ClockworkPi DevTerm portable (all cores)
>
> Signed-off-by: Max Fierke <max@...fierke.com>
> ---
> .../display/panel/clockworkpi,cwd686.yaml | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml
You probably can simply add this to panel-simple-dsi.yaml. It mainly
depends on how many power supplies this panel has.
>
> diff --git a/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml b/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml
> new file mode 100644
> index 000000000000..935a33b9305f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/clockworkpi,cwd686.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ClockworkPi CWD686 6.86" IPS LCD panel
> +
> +maintainers:
> + - Max Fierke <max@...fierke.com>
> +
> +description: |
> + The ClockworkPi CWD686 is a 6.86" ICNL9707-based IPS LCD panel used within the
> + ClockworkPi DevTerm series of portable devices. The panel has a 480x1280
> + resolution and uses 24 bit RGB per pixel.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: clockworkpi,cwd686
> +
> + reg:
> + description: DSI virtual channel used by that screen
> + maxItems: 1
> +
> + reset-gpios: true
> + rotation: true
> + backlight: true
> +
> +required:
> + - compatible
> + - reg
> + - backlight
> + - reset-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + backlight: backlight {
> + compatible = "gpio-backlight";
> + gpios = <&gpio4 30 GPIO_ACTIVE_HIGH>;
> + };
> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel@0 {
> + compatible = "clockworkpi,cwd686";
> + reg = <0>;
> + backlight = <&backlight>;
> + reset-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>;
> + rotation = <90>;
> + };
> + };
> --
> 2.36.1
>
>
Powered by blists - more mailing lists