linux-kernel - Re: [PATCH v2] ata: pata_octeon_cf: Fix refcount leak in octeon_cf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d7d546b-e3c0-cd87-522e-c537ddc949bb@omp.ru>
Date:   Wed, 1 Jun 2022 22:01:06 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Miaoqian Lin <linmq006@...il.com>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Jeff Garzik <jgarzik@...hat.com>,
        David Daney <david.daney@...ium.com>,
        <linux-ide@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ata: pata_octeon_cf: Fix refcount leak in
 octeon_cf_probe

Hello!

On 6/1/22 11:59 AM, Miaoqian Lin wrote:

> of_find_device_by_node() takes reference, we should use put_device()
> to release it when not need anymore.
> Add missing put_device() to avoid refcount leak.
> 
> Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey