lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202206020506.JJRuspb2-lkp@intel.com>
Date:   Thu, 2 Jun 2022 05:28:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     David Howells <dhowells@...hat.com>
Cc:     kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:dhowells/linux-fs/netfs-linked-list 37/59]
 fs/netfs/output.c:274:32: warning: unused variable 'cookie'

tree:   https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/netfs-linked-list
head:   22ecc2fcdab4616e624408911ec1d54644e82030
commit: 5c1c3ba2afbf95dfbd1cb36cae7a28e20c4eaace [37/59] netfs: Dispatch write requests to process a writeback slice
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20220602/202206020506.JJRuspb2-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/ammarfaizi2/linux-block/commit/5c1c3ba2afbf95dfbd1cb36cae7a28e20c4eaace
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/netfs-linked-list
        git checkout 5c1c3ba2afbf95dfbd1cb36cae7a28e20c4eaace
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/netfs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   fs/netfs/output.c: In function 'netfs_set_up_write_to_cache':
>> fs/netfs/output.c:274:32: warning: unused variable 'cookie' [-Wunused-variable]
     274 |         struct fscache_cookie *cookie = netfs_i_cookie(wreq->inode);
         |                                ^~~~~~


vim +/cookie +274 fs/netfs/output.c

   266	
   267	/*
   268	 * Set up a op for writing to the cache.
   269	 */
   270	static void netfs_set_up_write_to_cache(struct netfs_io_request *wreq)
   271	{
   272		struct netfs_cache_resources *cres;
   273		struct netfs_io_subrequest *subreq;
 > 274		struct fscache_cookie *cookie = netfs_i_cookie(wreq->inode);
   275		loff_t start = wreq->first * PAGE_SIZE;
   276		size_t len = (wreq->last - wreq->first + 1) * PAGE_SIZE;
   277		int ret;
   278	
   279		if (!fscache_cookie_enabled(cookie)) {
   280			clear_bit(NETFS_RREQ_WRITE_TO_CACHE, &wreq->flags);
   281			return;
   282		}
   283	
   284		_debug("write to cache");
   285		subreq = netfs_create_write_request(wreq, NETFS_WRITE_TO_CACHE, start, len,
   286						    netfs_write_to_cache_op_worker);
   287		if (!subreq)
   288			return;
   289	
   290		cres = &wreq->cache_resources;
   291		ret = -ENOBUFS;
   292		if (wreq->netfs_ops->begin_cache_operation)
   293			ret = wreq->netfs_ops->begin_cache_operation(wreq);
   294		if (ret < 0) {
   295			netfs_write_subrequest_terminated(subreq, ret, false);
   296			return;
   297		}
   298	
   299		ret = cres->ops->prepare_write(cres, &start, &len, i_size_read(wreq->inode),
   300					       true);
   301		if (ret < 0) {
   302			netfs_write_subrequest_terminated(subreq, ret, false);
   303			return;
   304		}
   305	
   306		netfs_queue_write_request(subreq);
   307	}
   308	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ