linux-kernel - Re: [RFC PATCH v6 006/104] KVM: TDX: Detect CPU feature on kernel module initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ec9be313961b4cb3771180a75a4767998c6fdc0.camel@intel.com>
Date:   Thu, 02 Jun 2022 10:11:09 +1200
From:   Kai Huang <kai.huang@...el.com>
To:     Isaku Yamahata <isaku.yamahata@...il.com>,
        Sagi Shahar <sagis@...gle.com>
Cc:     "Yamahata, Isaku" <isaku.yamahata@...el.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
        Erdem Aktas <erdemaktas@...gle.com>,
        Sean Christopherson <seanjc@...gle.com>
Subject: Re: [RFC PATCH v6 006/104] KVM: TDX: Detect CPU feature on kernel
 module initialization

On Thu, 2022-05-26 at 12:28 -0700, Isaku Yamahata wrote:
> +       if (!platform_has_tdx()) {
> +               if (__seamrr_enabled())
> +                       pr_warn("Cannot enable TDX with SEAMRR disabled\n");
> +               else
> +                       pr_warn("Cannot enable TDX on TDX disabled platform.\n");
> +               return -ENODEV;
> +       }

This is really overkill.  I cannot tell the difference between "SEAMRR disabled"
and "TDX disabled platform".

Btw, the v4 has removed __seamrr_enabled(), and there are other changes too. 
Could you rebase the KVM code to latest v4?

https://lore.kernel.org/lkml/cover.1654025430.git.kai.huang@intel.com/

-- 
Thanks,
-Kai