linux-kernel - Re: [PATCH] ARM: OMAP2+: Fix refcount leak in omapdss_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YpcMU9o8w/zoDE+J@pendragon.ideasonboard.com>
Date:   Wed, 1 Jun 2022 09:50:59 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Tony Lindgren <tony@...mide.com>,
        Russell King <linux@...linux.org.uk>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: Fix refcount leak in omapdss_init_of

Hello Lin,

Thank you for the patch.

On Wed, Jun 01, 2022 at 08:48:58AM +0400, Miaoqian Lin wrote:
> omapdss_find_dss_of_node() calls of_find_compatible_node() to get device
> node. of_find_compatible_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() in later error path and normal path.
> 
> Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  arch/arm/mach-omap2/display.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
> index 21413a9b7b6c..ed2cb2649cf6 100644
> --- a/arch/arm/mach-omap2/display.c
> +++ b/arch/arm/mach-omap2/display.c
> @@ -259,11 +259,13 @@ static int __init omapdss_init_of(void)
>  
>  	if (!pdev) {
>  		pr_err("Unable to find DSS platform device\n");
> +		of_node_put(node);
>  		return -ENODEV;
>  	}
>  
>  	r = of_platform_populate(node, NULL, NULL, &pdev->dev);
>  	put_device(&pdev->dev);
> +	of_node_put(node);
>  	if (r) {
>  		pr_err("Unable to populate DSS submodule devices\n");
>  		return r;

-- 
Regards,

Laurent Pinchart