linux-kernel - Re: [PATCH v3 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <95bbe6b0-1c56-9be9-0343-a24fe1970705@linaro.org>
Date:   Wed, 1 Jun 2022 09:12:09 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Georgi Djakov <djakov@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     Thara Gopinath <thara.gopinath@...aro.org>
Subject: Re: [PATCH v3 2/4] soc: qcom: icc-bwmon: Add bandwidth monitoring
 driver

On 31/05/2022 12:51, Krzysztof Kozlowski wrote:
> +	window = mult_frac(bwmon->sample_ms, HW_TIMER_HZ, MSEC_PER_SEC);
> +	/* Maximum sampling window: 0xfffff */
> +	writel_relaxed(window, bwmon->base + BWMON_SAMPLE_WINDOW);
> +
> +	bwmon_set_threshold(bwmon, BWMON_THRESHOLD_HIGH,
> +			    data->default_highbw_kbps);
> +	bwmon_set_threshold(bwmon, BWMON_THRESHOLD_MED,
> +			    data->default_medbw_kbps);
> +	bwmon_set_threshold(bwmon, BWMON_THRESHOLD_LOW,
> +			    data->default_lowbw_kbps);
> +
> +	thres_count = data->zone3_thres_count << BWMON_THRESHOLD_COUNT_ZONE3_SHIFT |
> +		      BWMON_THRESHOLD_COUNT_ZONE2_DEFAULT << BWMON_THRESHOLD_COUNT_ZONE2_SHIFT |
> +		      data->zone1_thres_count << BWMON_THRESHOLD_COUNT_ZONE1_SHIFT |
> +		      BWMON_THRESHOLD_COUNT_ZONE0_DEFAULT;
> +	writel_relaxed(thres_count, bwmon->base + BWMON_THRESHOLD_COUNT);
> +	writel_relaxed(BWMON_ZONE_ACTIONS_DEFAULT,
> +		       bwmon->base + BWMON_ZONE_ACTIONS);
> +
> +	/* Write barriers in bwmon_clear() */
> +	irq_enable = BIT(BWMON_IRQ_ENABLE_ZONE1_SHIFT) |
> +		     BIT(BWMON_IRQ_ENABLE_ZONE3_SHIFT);

Unusued variable, I will send a v4.



Best regards,
Krzysztof