linux-kernel - Re: [PATCH 09/14] dt-bindings: usb: Add Mediatek MT6370 TCPC binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f349852-34a7-ff27-3c34-462128802340@linaro.org>
Date:   Wed, 1 Jun 2022 09:26:12 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     ChiaEn Wu <peterwu.pub@...il.com>, lee.jones@...aro.org,
        daniel.thompson@...aro.org, jingoohan1@...il.com, pavel@....cz,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        matthias.bgg@...il.com, sre@...nel.org, chunfeng.yun@...iatek.com,
        gregkh@...uxfoundation.org, jic23@...nel.org, lars@...afoo.de,
        lgirdwood@...il.com, broonie@...nel.org, linux@...ck-us.net,
        heikki.krogerus@...ux.intel.com, deller@....de
Cc:     cy_huang@...htek.com, alice_chen@...htek.com,
        chiaen_wu@...htek.com, dri-devel@...ts.freedesktop.org,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH 09/14] dt-bindings: usb: Add Mediatek MT6370 TCPC binding
 documentation

On 31/05/2022 12:28, ChiaEn Wu wrote:
> From: ChiYuan Huang <cy_huang@...htek.com>
> 
> Add Mediatek MT6370 TCPC binding documentation.
> 
> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> ---
>  .../bindings/usb/mediatek,mt6370-tcpc.yaml    | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml
> new file mode 100644
> index 000000000000..49316633f92f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6370-tcpc.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/usb/mediatek,mt6370-tcpc.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Mediatek MT6370 Type-C Port Switch and Power Delivery controller DT bindings

s/DT bindings//

> +
> +maintainers:
> +  - ChiYuan Huang <cy_huang@...htek.com>
> +
> +description: |
> +  Mediatek MT6370 is a multi-functional device. It integrates charger, ADC, flash, RGB indicators,
> +  regulators (DSV/VIBLDO), and TypeC Port Switch with Power Delivery controller.
> +  This document only describes MT6370 Type-C Port Switch and Power Delivery controller.

These lines do not look like wrapped at 80.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - mediatek,mt6370-tcpc
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  connector:
> +    type: object
> +    $ref: /schemas/connector/usb-connector.yaml#

You need unevaluatedProperties:false within connector.

> +    description:
> +      Properties for usb c connector.

Skip description, it's not helpful.

> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - interrupts


Best regards,
Krzysztof