linux-kernel - Re: arch/arm64/kernel/fpsimd.c:1944:55: sparse: sparse: dereference of noderef expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YpcaTwI4SvV3IrwF@sirena.org.uk>
Date:   Wed, 1 Jun 2022 09:50:39 +0200
From:   Mark Brown <broonie@...nel.org>
To:     Catalin Marinas <catalin.marinas@....com>
Cc:     kernel test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: arch/arm64/kernel/fpsimd.c:1944:55: sparse: sparse: dereference
 of noderef expression

On Tue, May 31, 2022 at 05:57:42PM +0100, Catalin Marinas wrote:

> This looks wrong indeed. IIUC, something like below but waiting for Mark
> to confirm:
> 
> diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
> index 819979398127..ac521b3403d6 100644
> --- a/arch/arm64/kernel/fpsimd.c
> +++ b/arch/arm64/kernel/fpsimd.c
> @@ -1965,7 +1965,7 @@ void __efi_fpsimd_end(void)
>  							   0,
>  							   SVCR_SM_MASK);
>  					if (!system_supports_fa64())
> -						ffr = efi_sm_state;
> +						ffr = false;

Yes, that looks right - feel free to add my Reviewed-by or I'll
do that when I see the patch sent properly.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)