linux-kernel - Re: [PATCH 3/3] mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba64cd1b-c8ee-a4eb-f0cd-e16c26777d46@redhat.com>
Date:   Wed, 1 Jun 2022 11:32:37 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Muchun Song <songmuchun@...edance.com>, mike.kravetz@...cle.com,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        smuchun@...edance.com
Subject: Re: [PATCH 3/3] mm: hugetlb_vmemmap: cleanup
 CONFIG_HUGETLB_PAGE_FREE_VMEMMAP*

On 04.04.22 09:46, Muchun Song wrote:
> The word of "free" is not expressive enough to express the feature of optimizing
> vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze".
> In this patch , cheanup configs to make code more expressive.

Nit: why not simply CONFIG_HUGETLB_OPTIMIZE_VMEMMAP if we're touching
this already? At least I don't see value in the additional "PAGE" :)

> 
> Signed-off-by: Muchun Song <songmuchun@...edance.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt |  4 ++--
>  Documentation/admin-guide/mm/hugetlbpage.rst    |  2 +-
>  arch/arm64/Kconfig                              |  2 +-
>  arch/arm64/mm/flush.c                           |  2 +-
>  arch/x86/Kconfig                                |  2 +-
>  arch/x86/mm/init_64.c                           |  2 +-
>  fs/Kconfig                                      | 16 ++++++++--------
>  include/linux/hugetlb.h                         |  2 +-
>  include/linux/mm.h                              |  2 +-
>  include/linux/page-flags.h                      |  6 +++---
>  mm/Makefile                                     |  2 +-
>  mm/hugetlb_vmemmap.c                            |  4 ++--
>  mm/hugetlb_vmemmap.h                            |  4 ++--
>  mm/sparse-vmemmap.c                             |  4 ++--
>  14 files changed, 27 insertions(+), 27 deletions(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 56edbe3f458f..89a58ac49d5f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1660,7 +1660,7 @@
>  			Format: size[KMG]
>  
>  	hugetlb_free_vmemmap=

We didn't change the parameter name in #2, correct?


-- 
Thanks,

David / dhildenb