linux-kernel - Re: [PATCH v2 1/3] ARM64: dts: add dts files for bcmbca SoC bcm6858

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Jun 2022 02:48:35 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Anand Gore <anand.gore@...adcom.com>,
        Linux ARM List <linux-arm-kernel@...ts.infradead.org>
Cc:     kursad.oney@...adcom.com, joel.peshkin@...adcom.com,
        samyon.furman@...adcom.com, tomer.yacoby@...adcom.com,
        dan.beygelman@...adcom.com,
        William Zhang <william.zhang@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] ARM64: dts: add dts files for bcmbca SoC bcm6858



On 5/31/2022 11:46 AM, Anand Gore wrote:
> Add dts for ARMv8 based broadband SoC BCM6858.
> bcm6858.dtsi is the SoC description dts header
> and bcm96858.dts is a simple dts file for Broadcom
> BCM96858 Reference board that only enables the UART port.
> 
> Signed-off-by: Anand Gore <anand.gore@...adcom.com>
> 
> ---
[snip]

> +	axi@...00000 {
> +		compatible = "simple-bus";
> +		#address-cells = <2>;
> +		#size-cells = <2>;

See my comment to William, I don't think this is quite what you want, 
you should use #address-cells and #size-cells = 1 here and adjust the 
reg nodes accordingly.
-- 
Florian