linux-kernel - Re: [PATCH] staging: r8188eu: Drop redundant memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <007ab767-b124-26fd-20f4-29fea899a573@lwfinger.net>
Date:   Wed, 1 Jun 2022 05:01:28 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Haowen Bai <baihaowen@...zu.com>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Drop redundant memset

On 6/1/22 04:35, Haowen Bai wrote:
> The region set by the call to memset is immediately overwritten by the
> subsequent call to memcpy. So we drop redundant memset.
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>   drivers/staging/r8188eu/core/rtw_mlme.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
> index 5a815642c3f6..56c8bd5f4c60 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme.c
> @@ -676,7 +676,6 @@ void rtw_surveydone_event_callback(struct adapter	*adapter, u8 *pbuf)
>   
>   					_clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY);
>   
> -					memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
>   					memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
>   
>   					rtw_update_registrypriv_dev_network(adapter);
> @@ -1253,7 +1252,6 @@ void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf)
>   
>   			memcpy(pdev_network, &tgt_network->network, get_wlan_bssid_ex_sz(&tgt_network->network));
>   
> -			memset(&pdev_network->Ssid, 0, sizeof(struct ndis_802_11_ssid));
>   			memcpy(&pdev_network->Ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_802_11_ssid));
>   
>   			rtw_update_registrypriv_dev_network(adapter);

You supplied two patches with the same subject that do different things. That is 
confusing to everyone. Please redo with unique subjects.

Larry