linux-kernel - Re: [PATCH V2] staging: r8188eu: Drop redundant memset overwritten by memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Jun 2022 12:18:28 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     larry.finger@...inger.net, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev, phil@...lpotter.co.uk
Subject: Re: [PATCH V2] staging: r8188eu: Drop redundant memset overwritten
 by memcpy

On Wed, Jun 01, 2022 at 06:05:26PM +0800, Haowen Bai wrote:
> The region set by the call to memset is immediately overwritten by the
> subsequent call to memcpy. So we drop redundant memset.
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
> V1->V2: change title for unique subjects.

That's not really unique, why is this just not 1 patch with both changes
in it as you are doing the same thing to the same driver source, just in
different locations in the files.

Please merge together.

thanks,

greg k-h