linux-kernel - Re: [PATCH V12 02/24] irqchip/loongson-liointc: Fix build error for LoongArch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61034cb8-8847-0ca5-897d-a607f24bc6ba@xen0n.name>
Date:   Wed, 1 Jun 2022 18:37:42 +0800
From:   WANG Xuerui <kernel@...0n.name>
To:     Huacai Chen <chenhuacai@...ngson.cn>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-arch@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Huacai Chen <chenhuacai@...il.com>,
        Guo Ren <guoren@...nel.org>, Xuerui Wang <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH V12 02/24] irqchip/loongson-liointc: Fix build error for
 LoongArch

On 6/1/22 17:59, Huacai Chen wrote:
> liointc driver is shared by MIPS and LoongArch, this patch adjust the
> code to fix build error for LoongArch.
>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> ---
>   drivers/irqchip/irq-loongson-liointc.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-loongson-liointc.c b/drivers/irqchip/irq-loongson-liointc.c
> index 649c58391618..aed88857d90f 100644
> --- a/drivers/irqchip/irq-loongson-liointc.c
> +++ b/drivers/irqchip/irq-loongson-liointc.c
> @@ -16,7 +16,11 @@
>   #include <linux/smp.h>
>   #include <linux/irqchip/chained_irq.h>
>   
> +#ifdef CONFIG_MIPS
>   #include <loongson.h>
> +#else
> +#include <asm/loongson.h>
> +#endif
>   
>   #define LIOINTC_CHIP_IRQ	32
>   #define LIOINTC_NUM_PARENT 4
> @@ -53,7 +57,7 @@ static void liointc_chained_handle_irq(struct irq_desc *desc)
>   	struct liointc_handler_data *handler = irq_desc_get_handler_data(desc);
>   	struct irq_chip *chip = irq_desc_get_chip(desc);
>   	struct irq_chip_generic *gc = handler->priv->gc;
> -	int core = get_ebase_cpunum() % LIOINTC_NUM_CORES;
> +	int core = cpu_logical_map(smp_processor_id()) % LIOINTC_NUM_CORES;
>   	u32 pending;
>   
>   	chained_irq_enter(chip, desc);

Trivial enough.

Reviewed-by: WANG Xuerui <git@...0n.name>