linux-kernel - Re: [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Jun 2022 12:52:18 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Miaoqian Lin <linmq006@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Mallikarjun Kasoju <mkasoju@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: max77620: Fix refcount leak in
 max77620_initialise_fps

On 01/06/2022 06:32, Miaoqian Lin wrote:
> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof