linux-kernel - Re: [PATCH 08/11] ARM: dts: qcom: sdx65-mtp: Increase the vmalloc size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 1 Jun 2022 13:06:02 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rohit Agarwal <quic_rohiagar@...cinc.com>, agross@...nel.org,
        bjorn.andersson@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, wim@...ux-watchdog.org,
        linux@...ck-us.net
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
        manivannan.sadhasivam@...aro.org
Subject: Re: [PATCH 08/11] ARM: dts: qcom: sdx65-mtp: Increase the vmalloc
 size

On 01/06/2022 12:45, Rohit Agarwal wrote:
> Increase the size of vmalloc using the bootargs in sdx65
> mtp board.
> It is failing to alloacte the size needed for firmware and
> giving the error logs due to actual vmalloc region lesser than requested.
> 
> cat /proc/meminfo shows the size of VmallocTotal as 245760 kB.
> 
> [ 10.980356] vmap allocation for size 268439552 failed: use vmalloc=<size> to increase size
> [ 10.980505] qcom_q6v5_pas 4080000.remoteproc: unable to map memory region: 0x90800000+10000000
> [ 10.988542] In adsp alloc memory: adsp_probe 482
> [ 10.988592] remoteproc remoteproc0: releasing 4080000.remoteproc
> [ 11.001598] qcom_q6v5_pas: probe of 4080000.remoteproc failed with error -16
> 
> Thus, increasing the size to 300000000 as modem is not the only one using vmalloc region.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@...cinc.com>
> ---
>  arch/arm/boot/dts/qcom-sdx65-mtp.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> index 85ea02d..966385f 100644
> --- a/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> @@ -21,6 +21,7 @@
>  
>  	chosen {
>  		stdout-path = "serial0:115200n8";
> +		bootargs = "vmalloc=300000000";

I understand that issue comes from SoC-related driver but this is not a
property of the hardware. This could be added by bootloader if needed,
but in regular case this is a system setup parameter, so it does not
belong to DTS.

Best regards,
Krzysztof