linux-kernel - Re: [PATCH 2/3] mm: hugetlb_vmemmap: cleanup hugetlb_free_vmemmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27ea9c9e-cd1b-c92f-5fe5-ccb778d90f95@oracle.com>
Date:   Tue, 31 May 2022 17:01:36 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Muchun Song <songmuchun@...edance.com>, akpm@...ux-foundation.org,
        david@...hat.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        smuchun@...edance.com
Subject: Re: [PATCH 2/3] mm: hugetlb_vmemmap: cleanup
 hugetlb_free_vmemmap_enabled*

On 4/4/22 00:46, Muchun Song wrote:
> The word of "free" is not expressive enough to express the feature of optimizing
> vmemmap pages associated with each HugeTLB, rename this keywork to "optimeze".
> In this patch , cheanup the static key and hugetlb_free_vmemmap_enabled() to make
> code more expressive.

Commit message might look better as:

The keyword "free" is not expressive enough to describe the feature of
optimizing vmemmap pages associated with each HugeTLB page.  Rename the
keyword to "optimize".

Rename the static key and hugetlb_free_vmemmap_enabled() to make the code
more expressive.

> 
> Signed-off-by: Muchun Song <songmuchun@...edance.com>
> ---
>  arch/arm64/mm/flush.c      |  2 +-
>  include/linux/page-flags.h | 12 ++++++------
>  mm/hugetlb_vmemmap.c       | 10 +++++-----
>  mm/memory_hotplug.c        |  2 +-
>  4 files changed, 13 insertions(+), 13 deletions(-)

Code changes look fine,

Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>

-- 
Mike Kravetz