linux-kernel - Re: [PATCH V12 00/24] arch: Add basic LoongArch support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe537ea1-01a0-d963-ec8b-f73788e049b3@xen0n.name>
Date:   Wed, 1 Jun 2022 19:30:10 +0800
From:   WANG Xuerui <kernel@...0n.name>
To:     Huacai Chen <chenhuacai@...ngson.cn>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-arch@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Huacai Chen <chenhuacai@...il.com>,
        Guo Ren <guoren@...nel.org>, Xuerui Wang <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Eric Biederman <ebiederm@...ssion.com>,
        Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH V12 00/24] arch: Add basic LoongArch support

On 6/1/22 17:59, Huacai Chen wrote:
> <snip>
>
> Huacai Chen(24):
>   irqchip: Adjust Kconfig for Loongson.
>   irqchip/loongson-liointc: Fix build error for LoongArch.
>   Documentation: LoongArch: Add basic documentations.
>   Documentation/zh_CN: Add basic LoongArch documentations.
>   LoongArch: Add elf-related definitions.
>   LoongArch: Add writecombine support for drm.
>   LoongArch: Add build infrastructure.
>   LoongArch: Add CPU definition headers.
>   LoongArch: Add atomic/locking headers.
>   LoongArch: Add other common headers.
>   LoongArch: Add boot and setup routines.
>   LoongArch: Add exception/interrupt handling.
>   LoongArch: Add process management.
>   LoongArch: Add memory management.
>   LoongArch: Add system call support.
>   LoongArch: Add signal handling support.
>   LoongArch: Add elf and module support.
>   LoongArch: Add misc common routines.
>   LoongArch: Add some library functions.
>   LoongArch: Add PCI controller support.
>   LoongArch: Add VDSO and VSYSCALL support.
>   LoongArch: Add multi-processor (SMP) support.
>   LoongArch: Add Non-Uniform Memory Access (NUMA) support.
>   LoongArch: Add Loongson-3 default config file.
>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>

I have gone through every of these patches, and they now all look good 
to me. Thanks for all the revisions and cooperation!

I remember several more people have left comments on the v11 code; Eric 
commented on the signal handling bits and Ard may have something to say 
on the UEFI part. The first two cleanup patches to irqchip are 
previously sent in a separate series, and they are already trivial 
enough, but Marc may want to give the ack here too, for the patches to 
go in via the asm-generic tree.

At this time, although the port currently cannot work on any real 
hardware, the value is mostly for unblocking downstream development 
starting from the libc's, as the userspace ABI has been stable for 
several months already and there's probably no point in delaying even 
further. I've been working on the Gentoo/LoongArch port since August 
2021 and experienced every ABI break since then, so I probably know 
enough to make this statement.

I think, with the userspace ABI effectively stable already, and other 
implementation details available for continued improvement, we could 
make it into this merge window after all. People, please take a final 
quick look at this; your opinions and/or review and acks are appreciated.