linux-kernel - Re: [PATCH] mmc: sdhci-of-esdhc: Fix refcount leak in esdhc_signal_voltage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrtNLRT8prMuVXx9RBVfVuj_yj=KTj9nHaUg0t6euxUDg@mail.gmail.com>
Date:   Wed, 1 Jun 2022 14:46:12 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Adrian Hunter <adrian.hunter@...el.com>,
        yangbo lu <yangbo.lu@....com>, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci-of-esdhc: Fix refcount leak in esdhc_signal_voltage_switch

On Mon, 23 May 2022 at 16:43, Miaoqian Lin <linmq006@...il.com> wrote:
>
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
> of_node_put() checks null pointer.
>
> Fixes: ea35645a3c66 ("mmc: sdhci-of-esdhc: add support for signal voltage switch")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Queued for v5.20 on the devel branch, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-of-esdhc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index d9dc41143bb3..8b3d8119f388 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -904,6 +904,7 @@ static int esdhc_signal_voltage_switch(struct mmc_host *mmc,
>                 scfg_node = of_find_matching_node(NULL, scfg_device_ids);
>                 if (scfg_node)
>                         scfg_base = of_iomap(scfg_node, 0);
> +               of_node_put(scfg_node);
>                 if (scfg_base) {
>                         sdhciovselcr = SDHCIOVSELCR_TGLEN |
>                                        SDHCIOVSELCR_VSELVAL;
> --
> 2.25.1
>