lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Jun 2022 13:54:18 +0100 From: Matthew Wilcox <willy@...radead.org> To: Chen Wandun <chenwandun@...wei.com> Cc: hughd@...gle.com, akpm@...ux-foundation.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/4] mm/shmem: check return value of shmem_init_inodecache On Wed, Jun 01, 2022 at 08:44:14PM +0800, Chen Wandun wrote: > -static void shmem_init_inodecache(void) > +static struct kmem_cache *shmem_init_inodecache(void) > { > shmem_inode_cachep = kmem_cache_create("shmem_inode_cache", > sizeof(struct shmem_inode_info), > 0, SLAB_PANIC|SLAB_ACCOUNT, shmem_init_inode); > + > + return shmem_inode_cachep; > } > > static void shmem_destroy_inodecache(void) > @@ -3924,7 +3926,10 @@ void __init shmem_init(void) > { > int error; > > - shmem_init_inodecache(); > + if (!shmem_init_inodecache()) { > + error = -ENOMEM; > + goto out2; > + } better to return the errno from shmem_init_inodecache(): error = shmem_init_inodecache(); if (error) goto out2;
Powered by blists - more mailing lists