linux-kernel - RE: [PATCH] ASoC: Intel: cirrus-common: fix incorrect channel mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CY5PR11MB625789E6558FA1A0956A7E8197DF9@CY5PR11MB6257.namprd11.prod.outlook.com>
Date:   Wed, 1 Jun 2022 13:00:06 +0000
From:   "Lu, Brent" <brent.lu@...el.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
CC:     "Rojewski, Cezary" <cezary.rojewski@...el.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        "Mark Brown" <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        "liu, xiang" <xiang.liu@...rus.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ASoC: Intel: cirrus-common: fix incorrect channel mapping

> > +	int rx_ch[2] = {1, 0};
> 
> Should this be 'const'?
Will fix it.

> 
> I am also not clear on the mapping, how does this select the right channel?
> This selects slot0 and the left channel, what am I missing?

There are two DAC sources ASPRX1 and ASPRX2 which is on slot 0 and slot 1 by
default. And the DAC is using ASPRX1 as source. The {1, 0} will setup ASPRX1 to
be on slot 1 and ASPRX2 on slot 0 so the amps will be using slot 1 as DAC source.


> > @@ -134,6 +135,17 @@ static int cs35l41_hw_params(struct
> snd_pcm_substream *substream,
> >  				ret);
> >  			return ret;
> >  		}
> > +
> > +		/* Setup for R channel Slot: WR and TR */
> > +		if (i % 2) {
> > +			ret = snd_soc_dai_set_channel_map(codec_dai, 0,
> NULL,
> > +							  ARRAY_SIZE(rx_ch),
> rx_ch);
> > +			if (ret < 0) {
> > +				dev_err(codec_dai->dev, "fail to set channel
> map, ret %d\n",
> > +					ret);
> > +				return ret;
> > +			}
> > +		}
> 
> Should we do this loop for the left channels as well to have an explicit setting?

Will do it in V2 patch.

> 
> >  	}
> >
> >  	return 0;