linux-kernel - Re: [v2 PATCH 5/7] mm: thp: kill transparent_hugepage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHbLzkqfdFmiEymUfp=_mWK_6tRKeMe0pQ6fGAPLi=oL326LtQ@mail.gmail.com>
Date:   Thu, 2 Jun 2022 16:15:20 -0700
From:   Yang Shi <shy828301@...il.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Vlastimil Babka <vbabka@...e.cz>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux MM <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [v2 PATCH 5/7] mm: thp: kill transparent_hugepage_active()

On Thu, Jun 2, 2022 at 2:00 PM Matthew Wilcox <willy@...radead.org> wrote:
>
> On Thu, Jun 02, 2022 at 11:21:57AM -0700, Yang Shi wrote:
> > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
> > index 79d5919beb83..f315c70d5256 100644
> > --- a/include/linux/huge_mm.h
> > +++ b/include/linux/huge_mm.h
> > @@ -209,7 +209,9 @@ static inline bool file_thp_enabled(struct vm_area_struct *vma)
> >              !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode);
> >  }
> >
> > -bool transparent_hugepage_active(struct vm_area_struct *vma);
> > +extern bool hugepage_vma_check(struct vm_area_struct *vma,
>
> Please remove the 'extern's.  They add no value to function
> declarations.

Yeah, thanks for catching this.

>