linux-kernel - [PATCH v3] average: Clarify the restrictions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220602064307.18049-1-juitse.huang@gmail.com>
Date:   Thu,  2 Jun 2022 14:43:07 +0800
From:   Jui-Tse Huang <juitse.huang@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     Jui-Tse Huang <juitse.huang@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Johannes Berg <johannes.berg@...el.com>,
        Bruno Randolf <br1@...fach.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Ching-Chun Huang <jserv@...s.ncku.edu.tw>
Subject: [PATCH v3] average: Clarify the restrictions

There is several restrictions in the EWMA helper macro that the
developers should take care of, but the comment does not mentioned yet,
thus, this patch clarify the restrictions.

Signed-off-by: Jui-Tse Huang <juitse.huang@...il.com>
Acked-by: Randy Dunlap <rdunlap@...radead.org>
---

Notes:
    v3: fix typo (Randy Dunlap)
    v2: fix spelling and wording (Bruno Randolf)

 include/linux/average.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/include/linux/average.h b/include/linux/average.h
index a1a8f09631ce..9c3c8b5b518e 100644
--- a/include/linux/average.h
+++ b/include/linux/average.h
@@ -11,7 +11,10 @@
  *
  * This implements a fixed-precision EWMA algorithm, with both the
  * precision and fall-off coefficient determined at compile-time
- * and built into the generated helper funtions.
+ * and built into the generated helper functions.
+ *
+ * This implementation supports up to 30 bits of precision, and only
+ * the API for fetching non-fractional part is provided for now.
  *
  * The first argument to the macro is the name that will be used
  * for the struct and helper functions.
-- 
2.34.1